Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update my FPS patches and widescreen #331

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Update my FPS patches and widescreen #331

merged 1 commit into from
Sep 23, 2024

Conversation

PeterDelta
Copy link
Contributor

@PeterDelta PeterDelta commented Mar 5, 2024

I have already seen several users on the forum who are not clear about which 50/60 FPS patches to use in PAL versions. As we have added several patches to boot into NTSC or 480p video modes may cause confusion, I have simplified it and now it is clear, one patch to unlock FPS, either at 50 or 60, and another for video mode, either NTSC mode or 480p etc. I have updated some of them since they greatly increased the resources of the EE and now they perform better.

Other relevant changes aside:
Rogue Trooper: old patch is missing render fix, fixed

Rogue Trooper_SLES-52921_20240305110853

Rogue Trooper_SLES-52921_20240305110746

Area 51 SLES-53070 does not exist: There are only 3 PAL versions, SLED-53440, SLES-52570 and SLES-53075
http://redump.org/discs/quicksearch/area-51/sort/system/

Mercenaries 2: Old widescreen gives graphical glitches, fixed

Mercenaries 2 - World in Flames_SLES-55001_20240304161036
Mercenaries 2 - World in Flames_SLES-55001_20240304161431

Fixes #390
Fixes #356
Fixes #395

@pgert
Copy link
Contributor

pgert commented Mar 12, 2024

"Unlock FPS" would i my opinon be better in "description" as "Unlocks FPS".
"[50 FPS]", "[60 FPS]", or "[50/60 FPS]" tells more about what the hack does (better for end-users).

"Might need EE Overclock to be stable" is more of a comment than a description, yes?

@PeterDelta
Copy link
Contributor Author

"Unlock FPS" would i my opinon be better in "description" as "Unlocks FPS". "[50 FPS]", "[60 FPS]", or "[50/60 FPS]" tells more about what the hack does (better for end-users).

"Might need EE Overclock to be stable" is more of a comment than a description, yes?

I consider that as I have left it, it is the best for the end user since the title is self-descriptive and with a single quick glance you already know at what speed to increase the overclock, you do not have to read redundant things. We are adding NTSC or 480p video modes (I have several that I am testing that I will add later if everything goes well), if in the title it says [50 FPS] when adding NTSC it will no longer go to 50 but to 60, as in the The title says [50 FPS] and the user is left wondering whether to activate one, the other or both at the same time. I see it more logical, clean and clear this way.

@CRASHARKI
Copy link
Contributor

I tested the Crash Bandicoot patches and I unfortunately found some issues: Crash Nitro Kart and Crash Tag Team Racing seem to be zoomed-in (maybe just vertically), I specially noticed it on gameplay (Race in CNK and Platforming in CTTR) rather than the menus. Crash Twinsanity has issues with the FMVs, which are played while the game is running on the background forcing them to run 5 fps faster and therefore skiping audio from time to time. I tested one version of Crash of the Titans and it ran fine, the screen is finally fixed.

@PeterDelta
Copy link
Contributor Author

I tested the Crash Bandicoot patches and I unfortunately found some issues: Crash Nitro Kart and Crash Tag Team Racing seem to be zoomed-in (maybe just vertically), I specially noticed it on gameplay (Race in CNK and Platforming in CTTR) rather than the menus. Crash Twinsanity has issues with the FMVs, which are played while the game is running on the background forcing them to run 5 fps faster and therefore skiping audio from time to time. I tested one version of Crash of the Titans and it ran fine, the screen is finally fixed.

Crash Twinsanity the game runs fine but the FMVs don't sync, I overlooked it. I have deleted it. Crash Nitro Kart increases the resolution a little to 576, it's not really a problem, it maintains synchronized speed and FMV. Crash Tag Team Racing I don't see any errors, it runs well, the resolution is the same, speed and FMV are correct.

@CRASHARKI
Copy link
Contributor

Crash Nitro Kart has zooming issues. You can see in the screenshots that the hud and width is the same, but the rendered image is stretched vertically.
With no 480p patch:
Crash Nitro Kart_SLES-51511_20240315122030
With 480 patch:
Crash Nitro Kart_SLES-51511_20240315122137
About Crash Tag Team Racing I apologize, you are right, I checked againg and saw no issue, I must have done something wrong yesterday.

@PeterDelta
Copy link
Contributor Author

You're right, it seems that it doesn't look the same on all circuits, it's already deleted and I'll review it. Thank you

@CRASHARKI
Copy link
Contributor

Hey I felt bad for being such a party pooper, so I researched a bit and found the correct value for the CNK patch, you just have to change the last line that fixes the height of the screen to this and you get a perfect result: patch=1,EE,0058BF7C,word,3C023F00

@PeterDelta
Copy link
Contributor Author

PeterDelta commented Mar 15, 2024

Hey I felt bad for being such a party pooper, so I researched a bit and found the correct value for the CNK patch, you just have to change the last line that fixes the height of the screen to this and you get a perfect result: patch=1,EE,0058BF7C,word,3C023F00

It's okay mate, it's about making sure they are complete so that we can enjoy them in the best way and as they deserve ;). Yes, that is the default value but I modified it to fix the resolution issue, it seems to change depending on the circuit. When I fix it I'll upload it. At the moment this pull is ready.

Closes #390

@pgert
Copy link
Contributor

pgert commented Mar 19, 2024

If by "black bands" you mean blackbars, then I suggest you name it "blackbars" (which is 'standard'),
and that you place the hacks seperately, as in [Remove Blackbars].

@PeterDelta
Copy link
Contributor Author

PeterDelta commented Mar 19, 2024

If by "black bands" you mean blackbars, then I suggest you name it "blackbars" (which is 'standard'),
and that you place the hacks seperately, as in [Remove Blackbars].

That's right, I've counted over 110 widescreen patches that remove black bars in scenes and none of them are separate, I think it's part of the 16:9 display without cropping. Should we put them separately on all of them?

@pgert
Copy link
Contributor

pgert commented Mar 19, 2024

If by "black bands" you mean blackbars, then I suggest you name it "blackbars" (which is 'standard'),
and that you place the hacks seperately, as in [Remove Blackbars].

That's right, I've counted over 110 widescreen patches that remove black bars in scenes and none of them are separate, I think it's part of the 16:9 display without cropping. Should we put them separately on all of them?

Yes, do so.

@PeterDelta
Copy link
Contributor Author

If by "black bands" you mean blackbars, then I suggest you name it "blackbars" (which is 'standard'),
and that you place the hacks seperately, as in [Remove Blackbars].

That's right, I've counted over 110 widescreen patches that remove black bars in scenes and none of them are separate, I think it's part of the 16:9 display without cropping. Should we put them separately on all of them?

Yes, do so.

The ones in this pull are set aside, there are only another 100 left in the repository. I will open another pull later with more time

@RedDevilus
Copy link
Contributor

Not sure how Unlock FPS is less confusing than 50/60 FPS. If I see Unlock FPS I think of run as fast as possible like when you press F4 to uncap.

@PeterDelta
Copy link
Contributor Author

Not sure how Unlock FPS is less confusing than 50/60 FPS. If I see Unlock FPS I think of run as fast as possible like when you press F4 to uncap.

It doesn't seem like a logical deduction, since as you say that's what the F4 key is for and a patch like that doesn't make sense... apart from the fact that they wouldn't accept it here, of course.

@Mrlinkwii
Copy link
Contributor

please leave it to say 60 fps /50 fps :)

@RedDevilus
Copy link
Contributor

RedDevilus commented Mar 29, 2024

This is why you use the description section. To me it doesn't seem to fix the root concern of not confusing users and unintentionally creating a misleading term, if users don't get it even with revised and better description then it's not up to PCSX2 to make it easier for a minority.

Not saying there are no improvements to be made, just what a ton of people can agree with it is better. Maybe even creating a poll or showing specific words to multiple people and see if they get it?

But in it's current state, I would argue it is making it less obvious for majority, even PCSX2 forum calls it 50/60 FPS in the thread and other patches that are preincluded are also called that.

The title and description seems off for example:
IMG_20240329_024607.jpg

Maybe it's better to say in description that it doubles internal game FPS like 25/30 to 50/60?

@kamfretoz
Copy link
Contributor

Maybe it's better to say in description that it doubles internal game FPS like 25/30 to 50/60?

That, and also tell the user whether the patch needs a specific EE overclock level to be stable

@PeterDelta
Copy link
Contributor Author

PeterDelta commented Mar 29, 2024

It seems like it only looked good in my head xD. The title of the FPS patch in PAL remains at [50 FPS] or [50/60 FPS] depending on whether the game can be run at different Hz. Modified and revised

@PeterDelta PeterDelta changed the title Rename my FPS patches and updates Update my FPS patches and widescreen Mar 29, 2024
@pgert
Copy link
Contributor

pgert commented Jun 9, 2024

Nothing more to add.
This PR looks good to me.

@CRASHARKI
Copy link
Contributor

You might as well re-add the fixed Crash Nitro Kart 480p mode patch, right?

@PeterDelta
Copy link
Contributor Author

You might as well re-add the fixed Crash Nitro Kart 480p mode patch, right?

It is not fixed, the only thing left to correct is what you mentioned about the vertical axis of the image because its resolution increases to 576 and therefore the viewing area increases. I've been looking at it and so far I haven't found anything... It can be played well, I have enjoyed several circuits without problems but since the image is not the same as in 50 Hz I am not sure about including it

@CRASHARKI
Copy link
Contributor

It is not fixed, the only thing left to correct is what you mentioned about the vertical axis of the image because its resolution increases to 576 and therefore the viewing area increases. I've been looking at it and so far I haven't found anything... It can be played well, I have enjoyed several circuits without problems but since the image is not the same as in 50 Hz I am not sure about including it

Wasn't it fixed by just getting rid of the patch=1,EE,0058BF7C line in the patch? It looks good to me, no stretch issues. Can you specify in which case/level are you experiencing issues?

@PeterDelta
Copy link
Contributor Author

PeterDelta commented Jul 13, 2024

Wasn't it fixed by just getting rid of the patch=1,EE,0058BF7C line in the patch? It looks good to me, no stretch issues. Can you specify in which case/level are you experiencing issues?

Since this pull is ready, so as not to create confusion I will show it to you here and we will discuss
#390

Edit: Added 480p patch in Crash Nitro Kart tested

@PeterDelta
Copy link
Contributor Author

PeterDelta commented Jul 14, 2024

Shrek 2 PAL update: I passed several levels and completed the ending without errors.
The current patch in the gameplay works well but in the cutscenes it is too narrow. It seems to be a port of the NTSC version, in that version it is possible that the scenes look narrow as shown in this image, if someone can verify it, just do the port.

Shrek 2_SLES-52382_20240714204850
Current patch

Shrek 2_SLES-52382_20240714204812
4:3 original

Shrek 2_SLES-52382_20240714204811
New patch


Fixes #395 Need for speed underground: Fixed reflections and streetlights. It is valid for PAL and NTSC regions, corrected the fmv at the beginning that were shown cropped. I have completed all 112 circuits and I have not seen any more errors.

Need for Speed - Underground_SLES-51967_20240723130959
Current patch

Need for Speed - Underground_SLES-51967_20240723130855
New patch

@PeterDelta
Copy link
Contributor Author

Added more tested patches:

NBA Live 2001 PAL-E/S
NBA Live 2005 PAL-S
NBA Live 06 PAL-S
NBA Live 07 PAL-S
NBA Live 08 PAL-S
NBA Live 09 PAL-S

Burnout 3 Takedown PAL-M:
The current patch has a bug in 2 player mode. This has been fixed. The FPS patch keeps the entire game at 50/60 FPS, including FMVs and replays, without altering its original speed, it's amazing.

Current patch
Burnout 3 - Takedown_SLES-52584_20240729012810

New patch
Burnout 3 - Takedown_SLES-52584_20240729013000

@PeterDelta
Copy link
Contributor Author

Added: Torrente 3 El protector PAL-S SLES-53979
Final Armada PAL-M SLES-54467

Final Armada_SLES-54467_20240814115106
4:3 original

Final Armada_SLES-54467_20240814124337
New patch update, exact perspective for 16:9

Final Armada_SLES-54467_20240816160105
Current patch

@pgert
Copy link
Contributor

pgert commented Aug 18, 2024

Does "gsinterlacemode=1" make any difference in a "[480p Mode]" hack?
Isn't it of consequence only in a "[No-Interlacing]" hack?

@PeterDelta
Copy link
Contributor Author

Does "gsinterlacemode=1" make any difference in a "[480p Mode]" hack? Isn't it of consequence only in a "[No-Interlacing]" hack?

As you know, many widescreens are cropped even when native, that's why there are so many fixes. The same thing happens with progressive, many are cropped. Using gsinterlacemode=1 they fit perfectly to the image and no further adjustments are required other than perhaps speed or something else.

@Mrlinkwii
Copy link
Contributor

like as mentioned please dont use the word unlock

@PeterDelta
Copy link
Contributor Author

like as mentioned please dont use the word unlock

I just asked this and only a couple of people have given their opinion, please be patient.

@F0bes F0bes merged commit 6cab32a into PCSX2:main Sep 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants